Validate slice count before subtraction#117
Merged
ehrenfeu merged 3 commits intoimcf:develfrom Jan 19, 2026
Merged
Conversation
Contributor
lguerard
commented
Dec 8, 2025
lguerard
commented
- Added a check to ensure both images have the same number of slices.
- Exits with an error message if the slice counts differ.
- Adjusted the subtraction operation to handle stack images appropriately.
* Added a check to ensure both images have the same number of slices. * Exits with an error message if the slice counts differ. * Adjusted the subtraction operation to handle stack images appropriately.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #117 +/- ##
====================================
- Coverage 25% 24% -1%
====================================
Files 25 25
Lines 1688 1746 +58
====================================
+ Hits 421 425 +4
- Misses 1267 1321 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Ensure the calibration of the first image is applied to the result of the subtraction.
ehrenfeu
added
bug
ehrenfeu
requested changes
Jan 14, 2026
Member
|
Removed this from 2.0.0 in order to prevent it from blocking the release. Feel free to re-add once this is fixed or in case it's strictly necessary for the milestone. |
ehrenfeu
changed the title
ehrenfeu
approved these changes
Jan 19, 2026
Member
|
Add to changelog (cf. #126):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.